Skip to content

Scripts unit testing#184

Merged
cameronbateman-mo merged 34 commits intoMetOffice:mainfrom
james-bruten-mo:scripts_unit_testing
Feb 16, 2026
Merged

Scripts unit testing#184
cameronbateman-mo merged 34 commits intoMetOffice:mainfrom
james-bruten-mo:scripts_unit_testing

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Feb 9, 2026 •
edited by cameronbateman-mo
Loading

PR Summary

Sci/Tech Reviewer: @cameronbateman-mo
Code Reviewer: @yaswant

This PR tidies up python unit tests in this repo and adds unit testing CI:

  • Adds unit tests to get_git_sources.py
  • Rewrites apply_macros.py unit tests so that they don't require an lfric_apps clone, updates them for changes since moving to git and expands the coverage.
  • Fixes some unit tests in other areas, eg. nightly_testing
  • Adds a python unit tests CI workflow

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@james-bruten-mo james-bruten-mo marked this pull request as draft February 9, 2026 20:22
@james-bruten-mo james-bruten-mo marked this pull request as ready for review February 10, 2026 10:06
@james-bruten-mo
Copy link
Collaborator Author

james-bruten-mo commented Feb 10, 2026

I've won my fight with github actions - over to @cameronbateman-mo

cameronbateman-mo
cameronbateman-mo approved these changes Feb 16, 2026
View reviewed changes
Copy link
Contributor

@cameronbateman-mo cameronbateman-mo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, approved 😊

@github-actions github-actions bot requested a review from yaswant February 16, 2026 14:31
@cameronbateman-mo cameronbateman-mo merged commit 527a3ff into MetOffice:main Feb 16, 2026
12 checks passed
yaswant
yaswant reviewed Feb 17, 2026
View reviewed changes
Copy link
Collaborator

@yaswant yaswant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this PR has already been merged. However, @james-bruten-mo , since you asked me to review the workflow, I have a few suggestions that could be addressed in a separate PR.

.github/workflows/python_unit_tests.yaml
name: Python Unit Tests

on:
pull_request:
Copy link
Collaborator

@yaswant yaswant Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save the planet appeal :) - Only run if there is a change to Python files

Suggested change
pull_request:
pull_request:
paths:
- '**.py'
- '.github/workflows/python_unit_tests.yaml'

.github/workflows/python_unit_tests.yaml
python_unit_tests:
name: python_unit_tests
runs-on: ubuntu-24.04
timeout-minutes: 10
Copy link
Collaborator

@yaswant yaswant Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout-minutes: 10
timeout-minutes: 5

If it takes longer, it is not a unit test.

.github/workflows/python_unit_tests.yaml
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.14'
Copy link
Collaborator

@yaswant yaswant Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: '3.14'
python-version: '3.14'
cache: 'pip'

.github/workflows/python_unit_tests.yaml
Comment on lines +28 to +30
pip install pytest
pip install networkx
pip install PyYAML
Copy link
Collaborator

@yaswant yaswant Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install pytest
pip install networkx
pip install PyYAML
pip install pytest networkx PyYAML

.github/workflows/python_unit_tests.yaml
Comment on lines +33 to +34
git config --global user.name 'Testing'
git config --global user.email 'Testing'
Copy link
Collaborator

@yaswant yaswant Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the tests require commit? If not, then simply remove the git configs

Copy link
Collaborator Author

@james-bruten-mo james-bruten-mo Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah a couple of them require these setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaswant yaswant yaswant left review comments

@cameronbateman-mo cameronbateman-mo cameronbateman-mo approved these changes

Assignees

@james-bruten-mo james-bruten-mo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@james-bruten-mo @yaswant @cameronbateman-mo